feat: implement agent global state

[Jshen123]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
agent-gpt	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 29, 2023 7:46pm

[asim-shrestha]

an interface of

removeAgent: () => void;
setAgent: (newAgent: AutonomousAgent) => void;

Might make more sense. Remove agent would agent.stop(), setAgent(null) and also update isAgentStopped

[Jshen123]

@asim-shrestha removed setIsAgentStopped() since there is already a useEffect hook that update IsAgentStopped whenever agent is removed

AgentGPT/src/pages/index.tsx

Lines 72 to 74 in 6c58802

	useEffect(() => {
	setIsAgentStopped();
	}, [agent, setIsAgentStopped]);

[awtkns]

looking good! I will wait for @asim-shrestha though

[awtkns]

This seems a hard to work with. Any reason we cant do the below?

Suggested change

	export const [AGENT_STATUS_RUNNING, AGENT_STATUS_STOPPED] = [
	"running" as const,
	"stopped" as const,
	];
	const AgentStatusSchema = z.union([
	z.literal(AGENT_STATUS_RUNNING),
	z.literal(AGENT_STATUS_STOPPED),
	z.literal(""),
	]);
	export type AgentStatus = z.infer<typeof AgentStatusSchema>;
	export type AgentStatus = "running" | "stopped"

[Jshen123]

made it more concise 🎉

AgentGPT/src/types/agentTypes.ts

Lines 70 to 77 in a832040

	export const [AGENT_STATUS_RUNNING, AGENT_STATUS_STOPPED] = [
	"running" as const,
	"stopped" as const,
	];
	export type AgentStatus =
	| typeof AGENT_STATUS_RUNNING
	| typeof AGENT_STATUS_STOPPED;

keepingAGENT_STATUS_RUNNING and AGENT_STATUS_STOPPED because the strings "running" and "stopped" are referenced in many places.

[awtkns]

Not sure if this makes semantic sense. The above is saying:
"If the agent is not stopped and the agent exists then show stopping"
^ not sure that is right semantically

[Jshen123]

agreed, I could be wrong but this might be outdated code and imo we should just remove this completely.

my understanding is that this is handling a state where agent has been shutdown (i.e. set to null) but the agent?.isRunning has not been set to false

In today's code, agent?.isRunning and setAgent(null) happen simultaneous. I don't think this state would happen

AgentGPT/src/components/AutonomousAgent.ts

Lines 255 to 260 in 4e83cd0

	stopAgent() {
	this.sendManualShutdownMessage();
	this.isRunning = false;
	this.shutdown();
	return;
	}

CC: @asim-shrestha

[asim-shrestha]

Yeah lets refactor this after