This repository was archived by the owner on Jan 28, 2026. It is now read-only.
🐛 Fix bug that arises when using negative max_tokens#937
Merged
asim-shrestha merged 1 commit intomainfrom Jul 3, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
awtkns
approved these changes
Jul 3, 2023
| from reworkd_platform.web.api.agent.model_settings import WrappedChatOpenAI | ||
|
|
||
|
|
||
| class TokenService: |
Contributor
|
Love the tests ❤️ |
|
Hi 👋 Here's a preview environment 🚀 https://next-reworkd-agentgpt-937.env.ergomake.link Environment Summary 📑
Questions? Comments? Suggestions? Join Discord. Click here to disable Ergomake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
We can request a negative max token value when the completion tokens are that significant
This results in a strange response from OpenAI:
This PR will ensure we have a minimum value of 1
max_tokens. This will result in the following response:Also added some tests for this method and moved it into the token_service