Wrap gem loading to prevent prematurely loading ActiveRecord::Base#414
Open
nherzing wants to merge 1 commit intorgeo:8.0-stablefrom
Open
Wrap gem loading to prevent prematurely loading ActiveRecord::Base#414nherzing wants to merge 1 commit intorgeo:8.0-stablefrom
nherzing wants to merge 1 commit intorgeo:8.0-stablefrom
Conversation
Without this, loading the gem can trigger loading of ActiveRecord::Base prior to configuration occurs in Rails loading. This can result in certain ActiveRecord configurations to be ignored. Wrapping with `on_load` defers loading until it is appropriate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, loading the gem can trigger loading of
ActiveRecord::Baseprior to configuration occurs in Rails loading. This can result in certain ActiveRecord configurations to be ignored. Wrapping withon_loaddefers loading until it is appropriate.