Fix response size sum in metrics#99
Merged
riandyrn merged 2 commits intoriandyrn:masterfrom Mar 30, 2026
Merged
Conversation
Author
|
@riandyrn can you check this PR? |
Collaborator
|
Hello @bullet4791 Thanks for fixing this, I was able to confirm the issue as well and the change is makes sense Before merging this, could you also add a test case that covers this scenario? Specifically, it would be good to have a test where the response is written in multiple Write calls to ensure metric correctly accumulates the total bytes written which is should be FAIL before this patch. |
Author
|
Hello @ilhamsyahids |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix response size metric aggregation
The
http_server_response_size_bytes_summetric was incorrectly reporting zero becausewrittenByteswas only incremented on the firstWritecall, when!rrw.written. This ignored all subsequent writes, leading to inaccurate or zero size reporting, especially for responses written in multiple chunks.Updated the
Writehook to always incrementwrittenBytesby the actual number of written bytes (n), notlen(b), and to track the first non-zero write separately. This ensures accurate response size measurement regardless of write pattern.Changes:
writtenBytesaccumulationn(actual written bytes) instead oflen(b)writtenflag logic forWriteHeadertracking