Added meshadv mini radio profile and tested on hardware#1
Merged
rightup merged 4 commits intorightup:hardware/meshadvfrom Oct 20, 2025
Merged
Added meshadv mini radio profile and tested on hardware#1rightup merged 4 commits intorightup:hardware/meshadvfrom
rightup merged 4 commits intorightup:hardware/meshadvfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the Meshadv miniboard radio profile from Frequency Labs to the pyMC_Core library. The PR enables users to use the meshadv-mini hardware configuration alongside the existing Waveshare and uConsole radio options.
- Added meshadv-mini radio configuration to common.py with appropriate pin mappings and frequency settings
- Updated example scripts to support the new radio type through command-line arguments
- Enhanced documentation to include meshadv-mini setup instructions, pin configurations, and usage examples
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/send_flood_advert.py | Added meshadv-mini to accepted radio types and updated usage message |
| examples/common.py | Added meshadv-mini configuration profile and updated error message |
| docs/docs/node.md | Added comprehensive meshadv-mini documentation including setup and pin configuration |
| docs/docs/examples.md | Updated examples documentation to include meshadv-mini support |
| README.md | Added meshadv-mini to the list of supported radios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
update to calc in kHz Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Update to comment Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
update The setup instructions incorrectly reference 'Waveshare SX1262 HAT' when it should refer to the 'Frequency Labs meshadv-mini HAT' to match the section heading. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
Thanks! |
rightup
pushed a commit
that referenced
this pull request
Mar 6, 2026
…med - TODO #1 and #2 - Introduced `_pending_ack_crcs` to track pending ACK CRCs in `CompanionBase`, enhancing the handling of confirmed sends. - Refactored `_track_pending_ack` and `_apply_ack` methods to utilize the new `_try_confirm_send` method for improved clarity and functionality. - Updated `CompanionRadio` to clear pending ACKs upon key import and added an ACK received listener to the dispatcher for better integration. - Enhanced the dispatcher to support asynchronous ACK handling, ensuring efficient processing of received ACKs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a profile for the Meshadv miniboard from Frequency Labs. It tested successfully using the example. Feel free to reject, though, if you don't want to deal with it.