Feat/control packet Implement control packet handling for mesh node discovery#19
Merged
Feat/control packet Implement control packet handling for mesh node discovery#19
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements control packet handling for mesh node discovery, adding a new packet type (0x0B CONTROL) and handler infrastructure to enable nodes to discover each other on the mesh network via zero-hop broadcast packets.
Key Changes:
- Added
PAYLOAD_TYPE_CONTROL(0x0B) constant and corresponding packet type mapping - Implemented
ControlHandlerfor processing discovery request and response packets - Added
create_discovery_request()andcreate_discovery_response()methods toPacketBuilder - Provided two example scripts demonstrating discovery functionality
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
src/pymc_core/protocol/constants.py |
Added CONTROL (0x0B) and MULTIPART (0x0A) payload type constants |
src/pymc_core/protocol/utils.py |
Added string mappings for CONTROL and MULTIPART packet types |
src/pymc_core/protocol/packet_builder.py |
Implemented discovery request/response packet creation methods with proper encoding |
src/pymc_core/node/handlers/control.py |
New handler for processing control packets with callback-based discovery response collection |
src/pymc_core/node/handlers/__init__.py |
Exported ControlHandler for use by other modules |
src/pymc_core/node/dispatcher.py |
Registered ControlHandler as default handler for CONTROL packet type |
examples/discover_nodes.py |
Example demonstrating how to send discovery requests and collect responses |
examples/respond_to_discovery.py |
Example demonstrating how to listen for and respond to discovery requests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement control packet handling for mesh node discovery