Merged
Conversation
Improvements to - ACK flow, Timing and text message path handler logic
agessaman
added a commit
to agessaman/pyMC_core
that referenced
this pull request
Feb 28, 2026
…t natively -- TODO rightup#4 - Added `_apply_advert_to_stores` method to streamline the application of adverts to the contact store and path cache, improving contact handling efficiency. - Updated `CompanionBridge` to utilize the new method for processing adverts during node discovery, ensuring contacts are added or updated correctly. - Refactored `Contact` model to include a `from_dict` class method for constructing contact instances from various data sources, enhancing flexibility and maintainability. - Improved error handling in advert processing to ensure robustness during contact updates and path cache management.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.