fix(frontend): render invite pages with runtime office info#99
Open
yangcongcong-coding wants to merge 1 commit intoringhyacinth:masterfrom
Open
fix(frontend): render invite pages with runtime office info#99yangcongcong-coding wants to merge 1 commit intoringhyacinth:masterfrom
yangcongcong-coding wants to merge 1 commit intoringhyacinth:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- render the join/invite pages with the runtime office name instead of a hardcoded brand\n- build the invite/join links from the current request host so self-hosted deployments show the correct URL\n- add regression coverage to prevent office.example.com placeholders from leaking into the rendered pages\n\n## Verification\n- python -m unittest backend/tests/test_dynamic_pages.py -v