Conversation
- websocket sendStringAsync/sendBytesAsync now returns a Promise instead of a Future
…e error listener is triggered
…`java.nio.channels.ClosedChannelException`s
no other changes in code besides switching from `javax.servlet` to `jakarta.server` namespace
botic
approved these changes
Mar 25, 2022
Member
botic
left a comment
botic
left a comment
There was a problem hiding this comment.
Looks good for me. I would suggest merging asap and releasing 3.1.0 with early April, since Jetty 9 will go EOL in this month.
Member
|
Lgtm. With some promises ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#442 Upgrades Jetty to 11.0.8
in addition upgrades gradle to 7.4.1