Vector coverage update and Vf running#924
Merged
davidharrishmc merged 22 commits intoriscv:act4from Feb 12, 2026
Merged
Conversation
… into VectorTestFix
… into VectorTestFix
… into VectorTestFix
… into vectorcoverage
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to restore/expand vector functional coverage (“Vx” and “Vf”) by updating the vector test generator and multiple coverage templates, plus small adjustments to signature region handling and shared coverage macros.
Changes:
- Update vector test generation logic (signature update macros/args, mask generation, testplan expansion for Vf effew variants).
- Adjust unprivileged vector testgen coverpoint inclusion mapping and unsupported test list handling.
- Revise multiple coverage templates for widening/overlap coverpoints and XLEN-conditional sections; keep some shared ELEN selection logic as comments.
Reviewed changes
Copilot reviewed 3 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/env/test_setup.h | Removes RVTEST_VECTOR-only alignment before signature_base. |
| generators/testgen/scripts/vector_testgen_common.py | Updates template metadata, signature update register selection, mask generation op, and Vf testplan handling. |
| generators/testgen/scripts/vector-testgen-unpriv.py | Updates unsupported tests list, expands coverpoint inclusions for widening overlap, and changes initial vl setup emission. |
| generators/coverage/templates/cp_custom_wwv_all.txt | Adjusts bins for vs1 modulo coverpoints used in widening overlap scenarios. |
| generators/coverage/templates/cp_custom_wwv.txt | Same as above for non-“all” variant. |
| generators/coverage/templates/cp_custom_wvx_all.txt | Simplifies overlap/no-overlap coverpoints and updates bins/crosses. |
| generators/coverage/templates/cp_custom_wvx.txt | Same as above for non-“all” variant (contains a bin-name typo). |
| generators/coverage/templates/cp_custom_wvv_all.txt | Updates modulo bins and revises no-overlap/unaligned coverpoints used in crosses. |
| generators/coverage/templates/cp_custom_wvv.txt | Same as above for non-“all” variant. |
| generators/coverage/templates/cp_custom_vindexVX_sew8.txt | Updates XLEN guards and rs1 target literal width (currently incorrect for XLEN64). |
| generators/coverage/templates/cp_custom_vindexVX_sew32.txt | Updates XLEN guard and fixes rs1 target literal width for XLEN64. |
| generators/coverage/templates/cp_custom_vindexVX_sew16.txt | Updates XLEN guards and rs1 target literal widths. |
| framework/src/act/fcov/coverage/RISCV_coverage_common.svh | Comments out ELEN selection blocks (kept for future reference/config generation). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
davidharrishmc
left a comment
There was a problem hiding this comment.
One minor Copilot suggestion and then looks good.
davidharrishmc
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bringing back most of Vx coverage (left with 2 instructions that are not 100%) and Vf running.
The stuff in RISCV_coverage_common.svh are kept as comment instead of delete because these reference might come in handy when generating config files from UDB.