a lot of updates for this project #4
Open
Itzhep wants to merge 2 commits intoriseandignite:masterfrom
Open
Conversation
when i try to run the project i got error so i fixed the package.json file with "fs-extra": "^11.2.0",
**i formated code with prettier check the package.json for more details** Custom Logger Implementation Created a new logger.ts utility with: Singleton pattern for consistent logging Multiple log levels (info, warn, error, success, debug) Consistent formatting with icons and colors Specialized methods for scanning operations Debug mode toggle Timestamp support Replaced all direct console.log calls with logger methods Added structured logging for different types of messages Added explicit timeout error handling in server-connectors.ts Added file existence check in scanWithTreeDisplay Improved error messages with more context and actionable information Added proper error propagation and cleanup
Owner
|
hey @Itzhep, appreciate the effort here - lots of good stuff! but let’s keep PRs smaller and focused. it’s hard to review when one PR touches formatting, styles, utils, and logic at once. also please avoid changing styles or formatting unless that’s the goal of the PR. for now let's stick with current style. moving forward, let’s follow this format for PRs: for this one, could you split it into smaller PRs? e.g.:
makes it easier to review and merge quickly. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i add a lot of thing like formating code with prettier
adding custom logger
and fix some bugs
and a lot more, happy if you merge it :)
**Here's a summary of all changes **