Skip to content

a lot of updates for this project #4

Open
Itzhep wants to merge 2 commits intoriseandignite:masterfrom
Itzhep:master
Open

a lot of updates for this project #4
Itzhep wants to merge 2 commits intoriseandignite:masterfrom
Itzhep:master

Conversation

@Itzhep
Copy link

@Itzhep Itzhep commented Apr 16, 2025

i add a lot of thing like formating code with prettier
adding custom logger
and fix some bugs
and a lot more, happy if you merge it :)

**Here's a summary of all changes **

dev: Development mode with ts-node
test: Jest testing
lint: ESLint checking
format: Prettier formatting
prepare: Husky setup
prepublishOnly: Build before publishing
version: Format and add files before versioning
Added TypeScript ESLint plugins
Added Prettier for code formatting
Added Jest for testing
Added Husky for git hooks
Better development workflow tools

Itzhep added 2 commits April 16, 2025 18:04
when i try to run the project i got error so i fixed the package.json file with
"fs-extra": "^11.2.0",
**i formated code with prettier check the package.json for more details**

Custom Logger Implementation
Created a new logger.ts utility with:
Singleton pattern for consistent logging
Multiple log levels (info, warn, error, success, debug)
Consistent formatting with icons and colors
Specialized methods for scanning operations
Debug mode toggle
Timestamp support
Replaced all direct console.log calls with logger methods
Added structured logging for different types of messages

Added explicit timeout error handling in server-connectors.ts
Added file existence check in scanWithTreeDisplay
Improved error messages with more context and actionable information
Added proper error propagation and cleanup
@riseandignite
Copy link
Owner

hey @Itzhep, appreciate the effort here - lots of good stuff!

but let’s keep PRs smaller and focused. it’s hard to review when one PR touches formatting, styles, utils, and logic at once. also please avoid changing styles or formatting unless that’s the goal of the PR. for now let's stick with current style.

moving forward, let’s follow this format for PRs:

Title: [type] short description

Types:
- fix: for bug fixes only
- feat: for new features
- chore: for internal tooling (e.g. logger, prettier)
- refactor: for internal code improvements
- test: for adding tests
- docs: for documentation changes

PR format:
- What was changed?
- Why was it changed?
- Any risks or breaking changes?

for this one, could you split it into smaller PRs? e.g.:

  1. one for logger utility
  2. one for any specific bug fixes

makes it easier to review and merge quickly. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants