Introduce thread safe way to Close watcher and start it again#184
Open
JekaMas wants to merge 8 commits intorjeczalik:masterfrom
Open
Introduce thread safe way to Close watcher and start it again#184JekaMas wants to merge 8 commits intorjeczalik:masterfrom
JekaMas wants to merge 8 commits intorjeczalik:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thank you for the great project!
We faced with a couple goroutine leaks in Ethereum itself and forks(turbo geth), many of them appear in tests or user pattern "start-stop-start" node.
It'd be great to have notify package with thread safety and Close function.