fix crash on android emulator x86_64#224
Open
siddarthkay wants to merge 1 commit intorjeczalik:masterfrom
Open
fix crash on android emulator x86_64#224siddarthkay wants to merge 1 commit intorjeczalik:masterfrom
siddarthkay wants to merge 1 commit intorjeczalik:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We discovered during our E2E tests that our android emulators (x86_64) were crashing with a syscal 232 stacktrace.
ref : status-im/status-legacy#17265
we traced those syscalls to this library and this library works fine on all linux architectures ( android inclusive ) except for amd64.
This PR introduces a build flag that does not build the problematic syscall for amd64 architectures only and adds a poorly performing fallback for those cases.