elinks crashes when opening a new tab if current tab is a gitub project

[aelmahmoudy]

Steps to reproduce the issue:

• Open a GitHub project page (say: github.com/rkd77/elinks)
• Open a new tab (my keybinding is t)

elinks crashes giving the following traceback:

elinks(dump_backtrace+0x41)[0x5959b1d2fa21]
elinks(+0xd238a)[0x5959b1cef38a]
elinks(+0xd24ae)[0x5959b1cef4ae]
/lib/x86_64-linux-gnu/libc.so.6(+0x45330)[0x708ff6a45330]
elinks(format_iframes+0x320)[0x5959b1ccd5b0]
elinks(render_document_frames+0x2b8)[0x5959b1cdccc8]
elinks(draw_formatted+0x3e)[0x5959b1d3876e]they start
elinks(doc_loading_callback+0xf9)[0x5959b1d1c2c9]
elinks(+0xcc226)[0x5959b1ce9226]
elinks(+0xccc49)[0x5959b1ce9c49]
elinks(abort_connection+0x35)[0x5959b1cea745]
elinks(+0xc72bf)[0x5959b1ce42bf]
/usr/lib/x86-64-gnu/libev.so.4(ev_invoke_pending+0x55)[0x708ff8404515]
/usr/lib/x86-64-gnu/libev.so.4(ev_run+0x907)[0x708ff84076b7]
/usr/lib/x86-64-gnu/libev.so.4(event_base_loop+0x9)[0x708ff8409a49]
elinks(select_loop+0x6d8)[0x5959b1ce4e68]
elinks(main+0x40)[0x5959b1c7e550]
/lib/x86_64-linux-gnu/libc.so.6(+0x2a1ca)[0x708ff6a2a1ca]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0x8b)[0x708ff6a2a28b]
elinks(_start+0x25)[0x5959b1c7e6a5]
fish: Job 1, 'elinks -no-connect' terminated by signal SIGABRT (Abort)

The following features are enabled in my elinks build:

Standard, Fastmem, IPv6, brotli(1.1.0), gzip(1.3), bzip2(1.0.8),
lzma(5.4.5), gpm(2.1.0), UTF-8, libev (disabled)(4.33), terminfo
(disabled), Periodic Saving, Viewer (Search History, Timer, Marks),
gettext (System), Cascading Style Sheets, Protocol (Authentication,
BitTorrent, File, CGI, Finger, FSP, FTP, FTPES(libcurl/8.5.0
GnuTLS/3.8.3 zlib/1.3 brotli/1.1.0 zstd/1.5.5 libidn2/2.3.7
libpsl/0.21.2 (+libidn2/2.3.7) libssh/0.10.6/openssl/zlib
nghttp2/1.59.0 librtmp/2.3 OpenLDAP/2.6.7), Gemini, Gopher, HTTP,
Mailcap, Mailcap html, NNTP, SFTP, spartan, URI rewrite, User
protocols), SSL (GnuTLS 3.8.3), MIME (Option system, Mailcap, Mimetypes
files), LED indicators, Bookmarks, Cookies, Form History, Global
History, Scripting (Lua 5.3.6, Perl 5.38.2, Python 3.12.3), Exmode,
Goto URL History

[rkd77]

I can confirm, crashed for me too. For now (temporary solution) user can disable js on this site adding:
https://github.com/ to ~/.config/elinks/disallow.txt

[aelmahmoudy]

@rkd77 said:

I can confirm, crashed for me too. For now (temporary solution) user can disable js on this site adding: `https://github.com/` to ~/.config/elinks/disallow.txt

But my ELinks build does not have Javascript enabled

[rkd77]

Hm. No idea.
I added this commit 8cbb54c . It can be related, it can help. Less frequent segfaults.
valgrind --log-file=log --exit-on-first-error=yes elinks can log early bugs.

[aelmahmoudy]

@rkd77 said:

I added this commit 8cbb54c . It can be related, it can help. Less frequent segfaults.

Didn't try this yet. Yet I don't think it would be related to my issue, as I am using libev not libuv

[rkd77]

This commit's title starts with [forms]. This commit has nothing common with libuv. I guess you could cherry-pick it to 0.19.0.

[aelmahmoudy]

@rkd77 said:

This commit's title starts with [forms]. This commit has nothing common with libuv. I guess you could cherry-pick it to 0.19.0.

Oh, I was mistaken in my last comment indeed. I just included that commit to 0.19.0, and tried it, yet the same issue persists. I am testing on Ubuntu noble, here's the build: https://launchpad.net/~aelmahmoudy/+archive/ubuntu/ppa/+sourcepub/18053609/+listing-archive-extra Btw, adding `https://github.com/` to ~/.config/elinks/disallow.txt didn't fix the issue.

[aelmahmoudy]

Here's the output log when runnung: `valgrind --log-file=log --exit-on-first-error=yes elinks`: ``` ==2329944== Memcheck, a memory error detector ==2329944== Copyright (C) 2002-2022, and GNU GPL'd, by Julian Seward et al. ==2329944== Using Valgrind-3.22.0 and LibVEX; rerun with -h for copyright info ==2329944== Command: elinks ==2329944== Parent PID: 4025808 ==2329944== ==2329944== Invalid read of size 4 ==2329944== at 0x1B8570: format_iframes (in /home/m/mahmoudy/.local/bin/elinks) ==2329944== by 0x1C7C97: render_document_frames (in /home/m/mahmoudy/.local/bin/elinks) ==2329944== by 0x22373D: draw_formatted (in /home/m/mahmoudy/.local/bin/elinks) ==2329944== by 0x207298: doc_loading_callback (in /home/m/mahmoudy/.local/bin/elinks) ==2329944== by 0x1D41F5: ??? (in /home/m/mahmoudy/.local/bin/elinks) ==2329944== by 0x1D4C18: ??? (in /home/m/mahmoudy/.local/bin/elinks) ==2329944== by 0x1D5714: abort_connection (in /home/m/mahmoudy/.local/bin/elinks) ==2329944== by 0x1CF28E: ??? (in /home/m/mahmoudy/.local/bin/elinks) ==2329944== by 0x48A182A: ev_invoke_pending (in /usr/lib/x86_64-linux-gnu/libev.so.4.0.0) ==2329944== by 0x48A53B0: ev_run (in /usr/lib/x86_64-linux-gnu/libev.so.4.0.0) ==2329944== by 0x48A78FC: event_base_loop (in /usr/lib/x86_64-linux-gnu/libev.so.4.0.0) ==2329944== by 0x1CFE37: select_loop (in /home/m/mahmoudy/.local/bin/elinks) ==2329944== Address 0x1c4 is not stack'd, malloc'd or (recently) free'd ==2329944== ==2329944== ==2329944== Exit program on first error (--exit-on-first-error=yes) ```

[rkd77]

@aelmahmoudy I was able to reproduce it under Ubuntu.
Previous patch and this one and it ought to work.

[aelmahmoudy]

@rkd77 said:

Previous patch and this one and it ought to work.

Commit 886d8ee fixed the issue indeed. Thanks.