Fix allowClear option [Closes #63] #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`this.el.val()` returns +null+ when previously set to and empty string, and `shallowEqualFuzzy` returns false when comparing null to '' which causes an infinite onChange callback loop. The new `fuzzyValuesEqual` method returns +true+ when `currentValue` is +null+ and `newValue` is equal to an empty string, otherwise it calls `shallowEqualFuzzy` which was the previous behavior.
rkit
requested changes
Feb 28, 2017
examples/src/components/Tags.js
Outdated
| } | ||
|
|
||
| example11() { | ||
| const { value11, data11, onChange11 } = this.state; |
Owner
|
Thanks! |
Owner
|
I released a new beta version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
allowClearoption is enabled and that same component has aonChangecallback, clicking the clear icon will cause an infinite loop. The root cause seems to be thatthis.el.val()returnsnullwhen previously set to an empty string, which is what happens when the input is cleared. As expectedshallowEqualFuzzyreturnsfalsewhen comparingnullto''which causes an infiniteonChangecallback loop.The new
fuzzyValuesEqualmethod returnstruewhencurrentValueisnullandnewValueis equal to an empty string, otherwise it callsshallowEqualFuzzywhich was the previous behavior.I've also updated the examples with a select2 component set to
allowClearwhich can be used to manually test the new behavior. Let me know if there is anything you'd like me to change. Thanks! 😄