feat(renderer): add targetDocument option#703
Closed
layershifter wants to merge 2 commits intorobinweser:masterfrom
Closed
feat(renderer): add targetDocument option#703layershifter wants to merge 2 commits intorobinweser:masterfrom
targetDocument option#703layershifter wants to merge 2 commits intorobinweser:masterfrom
Conversation
layershifter
commented
Apr 23, 2019
| nodes: Object, | ||
| score: number, | ||
| { type, media, support }: NodeAttributes, | ||
| targetDocument: Document, |
Contributor
Author
There was a problem hiding this comment.
Order of params is changed because targetDocument is required
Contributor
Author
|
This PR actually adds changes to renderer 👎 Another approach is:
But, in this case we will hit cache issues ( @rofrischmann can I hear your feedback? 👂 |
7 tasks
Contributor
Author
|
Closing in favor of #704. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #693.
Description
This PR adds an
targetDocumentoption tocreateRenderer()that allows to render styles properly to child windows: microsoft/fluent-ui-react#1178Packages
felafela-domVersioning
Minor
Checklist
Quality Assurance
yarn run format)yarn run lint)yarn run test)yarn run flow)Changes