feat(RendererProvider): add target prop#718
Closed
layershifter wants to merge 1 commit intorobinweser:masterfrom
Closed
feat(RendererProvider): add target prop#718layershifter wants to merge 1 commit intorobinweser:masterfrom
target prop#718layershifter wants to merge 1 commit intorobinweser:masterfrom
Conversation
layershifter
commented
Jun 18, 2019
|
|
||
| import type { DOMRendererDocumentRef } from '../../../flowtypes/DOMRenderer' | ||
|
|
||
| const getDocumentRefIndex = ( |
Contributor
Author
There was a problem hiding this comment.
Can be replaced with .findIndex() but there is no such function in fast-loops and it's not supported by IE11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Another approach (from #704) for fixing #693.
RendererProviderNow this component accepts
targetprop like instyles-componentsStyleSheetManager.js#L25, it allows to specify aDocumentwhere style nodes will be attached.subscribeDocument()&documentRefsThis method is added to handle cases with passed documents, this implementation allows us to have a single subscription (difference from #704).
subscribeDocument()returns and object withunsubscribe()likesubscribe()does.However, we need to store
Documentobject somewhere, I propose:We need to have
refCountto know when we should remove matchingDocumentand clearrenderer.nodesto avoid memory leaks.refIdis used by buildreferencekey inrenderer.nodesbecause we can't rely on indexes.TODO
Example
Packages
List all packages that have been changed.
fela-bindingsfela-domfelareact-felaVersioning
Minor
Checklist
Quality Assurance
yarn run format)yarn run lint)yarn run test)yarn run flow)Changes
If one of the following checks doesn't make sense due to the type of PR, just check them.