Skip to content

Support for targetDocument#722

Merged
robinweser merged 1 commit intomasterfrom
targetDocument-support
Jul 29, 2019
Merged

Support for targetDocument#722
robinweser merged 1 commit intomasterfrom
targetDocument-support

Conversation

@robinweser
Copy link
Copy Markdown
Owner

@robinweser robinweser commented Jun 26, 2019

Description

This PR adds support for passing a targetDocument to fela-dom's render and rehydrate.
It can also be passed to the RendererProvider in react-fela, preact-fela and inferno-fela.
It will use the passed targetDocument to render the styles to.

Defaults to window.document.

Packages

List all packages that have been changed.

  • fela-dom
  • fela-bindings
    • react-fela
    • preact-fela
    • inferno-fela

Versioning

Minor

Checklist

Quality Assurance

You can also run yarn run check to run all 4 commands at once.

  • The code was formatted using Prettier (yarn run format)
  • The code has no linting errors (yarn run lint)
  • All tests are passing (yarn run test)
  • There are no flow-type errors (yarn run flow)

Changes

If one of the following checks doesn't make sense due to the type of PR, just check them.

  • Tests have been added/updated
  • Documentation has been added/updated
  • My changes have proper flow-types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant