Address review feedback for enqueue quiet mode#12
Merged
Conversation
Collaborator
wesm
commented
Jan 9, 2026
wesm
commented
- Print "Skipping: rebase in progress" when not in quiet mode
- Swallow HTTP errors in quiet mode (truly silent for hooks)
- Add tests for IsRebaseInProgress covering rebase-merge, rebase-apply, and non-repo cases
- Print "Skipping: rebase in progress" when not in quiet mode - Swallow HTTP errors in quiet mode (truly silent for hooks) - Add tests for IsRebaseInProgress covering rebase-merge, rebase-apply, and non-repo cases Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- --quiet now uses SilenceErrors/SilenceUsage to suppress output but preserves non-zero exit codes for actual failures (daemon/HTTP errors) - Only "not a repo" and "rebase in progress" exit 0 in quiet mode since those are expected conditions for hooks - Add worktree test for IsRebaseInProgress to ensure rebase detection works when .git is a file pointing to the real gitdir Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
andyxhadji
pushed a commit
to andyxhadji/roborev
that referenced
this pull request
Jan 9, 2026
- Print "Skipping: rebase in progress" when not in quiet mode - Swallow HTTP errors in quiet mode (truly silent for hooks) - Add tests for IsRebaseInProgress covering rebase-merge, rebase-apply, and non-repo cases --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.