Replace CoHTTP by a abstract interface#26
Merged
hannesm merged 2 commits intorobur-coop:masterfrom Jul 19, 2021
Merged
Conversation
- letsencrypt: core, few dependencies - letsencrypt-app: the client application - letsencrypt-dns: the DNS solver
Collaborator
|
I squashed your commis, and added another one that splits on the opam level this repository into three packages (to reduce dependency cones) |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Jul 19, 2021
CHANGES: Reduce dependency cone (robur-coop/ocaml-letsencrypt#26, @dinosaure & @hannesm) - remove cohttp dependency, provide a HTTP_client module type - provide letsencrypt-dns with dns solver - provide letsencrypt-app for the client binary
Collaborator
|
thanks! |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Jul 19, 2021
CHANGES: Reduce dependency cone (robur-coop/ocaml-letsencrypt#26, @dinosaure & @hannesm) - remove cohttp dependency, provide a HTTP_client module type - provide letsencrypt-dns with dns solver - provide letsencrypt-app for the client binary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a possible solution to delete CoHTTP from the core of
letsencrypt. (/cc @hannesm)