Improve the application and introduce paf-le as a standalone package#30
Merged
hannesm merged 7 commits intorobur-coop:masterfrom Feb 16, 2023
Merged
Improve the application and introduce paf-le as a standalone package#30hannesm merged 7 commits intorobur-coop:masterfrom
paf-le as a standalone package#30hannesm merged 7 commits intorobur-coop:masterfrom
Conversation
Collaborator
|
This looks mostly good. But I hesitate a bit about the module name Would LE_http_server or LE_http be a fine module name? |
hannesm
reviewed
Feb 6, 2023
hannesm
reviewed
Feb 6, 2023
Collaborator
|
Thanks @dinosaure, only some minor comments. Good to be merged. To avoid confusion:
ALPN is still used in here for HTTP 1.1 and HTTP 2 support :) |
Collaborator
|
Thanks, I'll merge this now, but wait for a release until the big split [tm] has settled. |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Feb 17, 2023
…tsencrypt-app (0.5.0) CHANGES: * adapt to mirage-crypto-rng 0.11.0 API changes (@hannesm) * upgrade bin/oacmel with cmdliner 1.1.0 (robur-coop/ocaml-letsencrypt#30 @dinosaure) * add new letsencrypt-mirage package (robur-coop/ocaml-letsencrypt#30 @dinosaure) * export HTTP_client module directly (robur-coop/ocaml-letsencrypt#30 @dinosaure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has a minor commit about the application and introduce what we did into
paf-le. The main difference is the usage ofhttp-mirage-clientas the HTTP client to do HTTP requests to Let's encrypt instead of an handmade hidden module which is an old version ofhttp-mirage-client. The goal is to delete duplication of code and finally usehappy-eyeballsas the DNS resolver instead of requiring agethostbyname./cc @hannesm