-
Notifications
You must be signed in to change notification settings - Fork 86
chore: slim CLI install by making heavy deps optional #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
c8d0bbc
97ee4b9
aea3b3b
2843bd3
49bcd85
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,15 +53,16 @@ | |
| "node": ">=18.0.0" | ||
| }, | ||
| "dependencies": { | ||
| "@skillkit/api": "workspace:*", | ||
| "@skillkit/core": "workspace:*", | ||
| "@skillkit/agents": "workspace:*", | ||
| "@skillkit/cli": "workspace:*", | ||
| "clipanion": "^4.0.0-rc.4" | ||
| }, | ||
| "optionalDependencies": { | ||
| "@skillkit/api": "workspace:*", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 Static re-export of optional dependency
Prompt for agentsWas this helpful? React with 👍 or 👎 to provide feedback. |
||
| "@skillkit/tui": "workspace:*", | ||
| "@skillkit/memory": "workspace:*", | ||
| "@skillkit/mesh": "workspace:*", | ||
| "@skillkit/messaging": "workspace:*", | ||
| "clipanion": "^4.0.0-rc.4" | ||
| "@skillkit/messaging": "workspace:*" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/node": "^22.10.5", | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,6 +1,7 @@ | ||||||||||||||||||||||||||||||||||
| // Re-export all public APIs from packages | ||||||||||||||||||||||||||||||||||
| export * from '@skillkit/core'; | ||||||||||||||||||||||||||||||||||
| export * from '@skillkit/agents'; | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| // Re-export TUI entry point | ||||||||||||||||||||||||||||||||||
| export { startTUI } from '@skillkit/tui'; | ||||||||||||||||||||||||||||||||||
| export async function startTUI(...args: unknown[]): Promise<unknown> { | ||||||||||||||||||||||||||||||||||
| const mod = await import('@skillkit/tui'); | ||||||||||||||||||||||||||||||||||
| return mod.startTUI(...(args as Parameters<typeof mod.startTUI>)); | ||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||
|
Comment on lines
+4
to
+7
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Description: Confirm the wrapper signature diverges from the actual `@skillkit/tui` startTUI signature.
printf '\napps/skillkit wrapper:\n'
rg -n -C2 'export async function startTUI' apps/skillkit/src/index.ts
printf '\n@skillkit/tui implementation:\n'
rg -n -C2 'export async function startTUI\(\): Promise<never>' packages/tui/src/index.tsxRepository: rohitg00/skillkit Length of output: 499 Preserve the original The dynamic import approach is correct, but this wrapper widens the API from Suggested fix-export async function startTUI(...args: unknown[]): Promise<unknown> {
+export async function startTUI(): Promise<never> {
const mod = await import('@skillkit/tui');
- return mod.startTUI(...(args as Parameters<typeof mod.startTUI>));
+ return mod.startTUI();
}📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents
Comment on lines
+4
to
+7
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Public API type regression: The
Suggested change
Was this helpful? React with 👍 or 👎 to provide feedback. |
||||||||||||||||||||||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.