fix: improve error for manualChunks' modules that are resolved as an external module#5050
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #5050 +/- ##
=======================================
Coverage 98.96% 98.97%
=======================================
Files 226 226
Lines 8348 8357 +9
Branches 2290 2293 +3
=======================================
+ Hits 8262 8271 +9
Misses 31 31
Partials 55 55
|
lukastaegert
reviewed
Jul 1, 2023
TrickyPi
commented
Jul 4, 2023
lukastaegert
reviewed
Jul 5, 2023
Member
lukastaegert
left a comment
lukastaegert
left a comment
There was a problem hiding this comment.
Looks great, just two minor stylistic issues I found, otherwise the code looks fine!
lukastaegert
reviewed
Jul 5, 2023
Co-authored-by: Lukas Taegert-Atkinson <lukastaegert@users.noreply.github.com>
Co-authored-by: Lukas Taegert-Atkinson <lukastaegert@users.noreply.github.com>
lukastaegert
approved these changes
Jul 6, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
TrickyPi
changed the title
TrickyPi
changed the title
Collaborator
|
This PR has been released as part of rollup@3.26.2. You can test it via |
This was referenced Jul 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
resolves #4633
Description
extend
loadEntryModuleandaddAdditionalModulesfunctions to know if it is a load for the manualChunks' module, then we can throw a correct error based on flagisLoadForManualChunks.