Skip to content

5.1.0 changes wrong input when using querySelector and multiple select #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fonji wants to merge 2 commits into from
Closed

5.1.0 changes wrong input when using querySelector and multiple select #47

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c85aa5
Setup test that fails when using querySelector and multiple inputs
fonji Oct 6, 2020
36284c6
:scissors:
fonji Oct 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/__tests__/select-event.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,31 @@ describe("The select event helpers", () => {
expect(form).toHaveFormValues({ food: "vanilla" });
});

it("selects options when there are multiple dropdowns", async () => {
const {container, getByRole} = render(
<form role="form">
<label htmlFor="food-for-monday">Food for monday</label>
<Select
options={OPTIONS} name="foodForMonday" inputId="food-for-monday"
formatOptionLabel={({ label }) => <div>This is a {label}</div>}
/>
<label htmlFor="food-for-tuesday">Food for tuesday</label>
<Select
options={OPTIONS} name="foodForTuesday" inputId="food-for-tuesday"
formatOptionLabel={({ label }) => <div>This is a {label}</div>}
/>
</form>
);
const form = getByRole("form");
const mondayInput = container.querySelector('input[name="foodForMonday"]')
const tuesdayInput = container.querySelector('input[name="foodForTuesday"]')

expect(form).toHaveFormValues({ foodForMonday: "", foodForTuesday: "" });
await selectEvent.select(mondayInput, /Chocolate/);
await selectEvent.select(tuesdayInput, /Chocolate/);
expect(form).toHaveFormValues({ foodForMonday: "chocolate", foodForTuesday: "chocolate" });
Copy link
Author

@fonji fonji Oct 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will fail, as foodForTuesday is ""

});

describe("when asynchronously generating the list of options", () => {
// from https://github.com/JedWatson/react-select/blob/v3.0.0/docs/examples/CreatableAdvanced.js
// mixed with Async Creatable Example from https://react-select.com/creatable
Expand Down