Skip to content

Byte swap values read from the protobuf raw data stream on big endian#10308

Merged
guitargeek merged 1 commit intoroot-project:masterfrom
ellert:bigendian-sofie
Apr 9, 2024
Merged

Byte swap values read from the protobuf raw data stream on big endian#10308
guitargeek merged 1 commit intoroot-project:masterfrom
ellert:bigendian-sofie

Conversation

@ellert
Copy link
Copy Markdown
Contributor

@ellert ellert commented Apr 4, 2022

This Pull request:

Changes or fixes:

Byte swap values read from the protobuf raw data stream on big endian

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #10146

@ellert ellert requested review from lmoneta and sitongan as code owners April 4, 2022 07:46
@phsft-bot
Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

  • [2022-04-04T09:07:35.337Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1083 (message):

@phsft-bot
Copy link
Copy Markdown

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

@ellert
Copy link
Copy Markdown
Contributor Author

ellert commented Nov 16, 2022

Rebased and updated.

@phsft-bot
Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

@ellert
Copy link
Copy Markdown
Contributor Author

ellert commented Dec 13, 2022

Now passes all the tests.

@andriish
Copy link
Copy Markdown
Contributor

Hi @lmoneta,

could you, please, have a look? The PR makes a lot of sense.

Best regards,

Andrii

Copy link
Copy Markdown
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for the fix!

I will just rebase the PR on master to trigger the new CI tests before merging.

@guitargeek guitargeek merged commit 7a39d4e into root-project:master Apr 9, 2024
@ellert ellert deleted the bigendian-sofie branch April 11, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Byte swapped floats in TMVA sofie on big endian architectures (s390x)

5 participants