[CMake] Check Python 3.8 requirement already in find_package(Python3)#15168
Merged
guitargeek merged 2 commits intoroot-project:masterfrom Apr 8, 2024
Merged
[CMake] Check Python 3.8 requirement already in find_package(Python3)#15168guitargeek merged 2 commits intoroot-project:masterfrom
find_package(Python3)#15168guitargeek merged 2 commits intoroot-project:masterfrom
Conversation
ROOT requires C++17 anyway, so this is redundant and can be confusing.
We should put the Python version check at the right place. Right now, the configuration logs tell you that ROOT requires Python 3.0, because there is no minimum version yet, which can be misleading.
Test Results 12 files 12 suites 2d 2h 27m 46s ⏱️ Results for commit 6831bc2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should put the Python version check at the right place.
Right now, the configuration logs tell you that ROOT requires Python
3.0, because there is no minimum version yet, which can be misleading.
Also, remove some redundant comments about the minimum C++ standard for
root7andwebgui.This PR should maybe be backported in one of the bulk backports, so the divergence between 6.32 and
masterdoesn't increase too much.