[tmva] Cleanup RModel classes layout#15170
Merged
vepadulano merged 3 commits intoroot-project:masterfrom Apr 8, 2024
Merged
Conversation
vepadulano
force-pushed
the
rmodel-remove-tobject
branch
from
9944fb0 to
42a440b
Compare
* Apply rule of five * Use correct `ClassDef` macro only when necessary * Remove relationship to `TObject` from `RModel_Base` * Properly implement virtual hierarchy for `RModel_GNNBase` and derived
vepadulano
force-pushed
the
rmodel-remove-tobject
branch
from
42a440b to
52ea8b0
Compare
Test Results 12 files 12 suites 2d 1h 8m 24s ⏱️ Results for commit c0e7947. ♻️ This comment has been updated with latest results. |
guitargeek
approved these changes
Apr 8, 2024
Contributor
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
Thanks! These changes make sense to me and go in the right direction 👍
pcanal
reviewed
Apr 8, 2024
| ClassDef(RModel_Base,1); | ||
|
|
||
| /** | ||
| Default constructor. Needed to allow serialization of ROOT objects. See |
Member
There was a problem hiding this comment.
Note if one need to have I/O without providing a default constructor, you can provide an alternate I/O constructor (you can even customize then name of the argument class if so desired).
class TRootIOCtor; // forward declaration.
....
RModel_Base(TRootIOCtor *) {}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a followup to #15163 and in relation to #15156
ClassDefmacro only when necessaryTObjectfromRModel_BaseRModel_GNNBaseand derivedAlso apply clang-format changes in a separate commit