Merged
Conversation
[ RUN ] VariableReflectionTest.StaticConstExprDatamember
/builddir/build/BUILD/root-6.36.00/interpreter/CppInterOp/unittests/CppInterOp/VariableReflectionTest.cpp:545: Failure
Expected equality of these values:
3
*(int*)offset
Which is: 0
/builddir/build/BUILD/root-6.36.00/interpreter/CppInterOp/unittests/CppInterOp/VariableReflectionTest.cpp:561: Failure
Expected equality of these values:
5
*(int*)offset
Which is: 0
/builddir/build/BUILD/root-6.36.00/interpreter/CppInterOp/unittests/CppInterOp/VariableReflectionTest.cpp:580: Failure
Expected equality of these values:
2
*(int*)offset
Which is: 0
[ FAILED ] VariableReflectionTest.StaticConstExprDatamember (9 ms)
Collaborator
|
Is this related to #14512 ? |
Test Results 19 files 19 suites 3d 7h 56m 5s ⏱️ Results for commit 7bfd27a. |
aaronj0
approved these changes
Jun 10, 2025
Contributor
There was a problem hiding this comment.
LGTM! Thanks for this useful patch, which will be upstreamed to CppInterOp
aaronj0
added a commit
to aaronj0/CppInterOp
that referenced
this pull request
Jun 10, 2025
This fixes failures on 32 bit platforms. Upstream of root-project/root#18992
aaronj0
added a commit
to aaronj0/CppInterOp
that referenced
this pull request
Jun 10, 2025
This fixes failures on 32 bit platforms. Upstream of root-project/root#18992
aaronj0
added a commit
to compiler-research/CppInterOp
that referenced
this pull request
Jun 10, 2025
This fixes failures on 32 bit platforms. Upstream of root-project/root#18992
Member
|
For the moment, this broke |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Offsets should use size_t. Using int causes test failures on Big Endian (s390x).