Skip to content

[histv7] Simplify class structure: #5986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Axel-Naumann wants to merge 1 commit into from
Closed

[histv7] Simplify class structure: #5986

Axel-Naumann wants to merge 1 commit into from

Conversation

@Axel-Naumann
Copy link
Member

@Axel-Naumann Axel-Naumann commented Jul 6, 2020 •
edited
Loading

Axis-type agnostic base; Fill happens through derived.
Gets rid of RHistImpl (soon).
Still needs some work, esp with C++14...
[skip-CI]

@Axel-Naumann
[histv7] Simplify class structure:
7058a7a 
Axis-type agnostic base; Fill happens through derived.
Gets rid of RHistImpl (soon).
Still needs some work, esp with C++14...
@phsft-bot
Copy link

phsft-bot commented Jul 6, 2020

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link

phsft-bot commented Jul 6, 2020

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

  • [2020-07-06T16:28:30.842Z] FAILED: hist/histv7/G__ROOTHist.cxx lib/ROOTHist.pcm
  • [2020-07-06T16:28:32.321Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RHist.hxx:105:31: error: expected expression
  • [2020-07-06T16:28:32.321Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RHist.hxx:142:49: error: no member named 'apply' in namespace 'std'
  • [2020-07-06T16:28:32.321Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RHist.hxx:170:41: error: no member named 'apply' in namespace 'std'
  • [2020-07-06T16:28:32.321Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RHist.hxx:183:41: error: no member named 'apply' in namespace 'std'
  • [2020-07-06T16:28:32.321Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RHistImpl.hxx:34:1: error: too few template parameters in template redeclaration
  • [2020-07-06T16:28:32.321Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RHistImpl.hxx:74:31: error: no template named 'CoordArray_t' in namespace 'ROOT::Experimental::Hist'
  • [2020-07-06T16:28:32.321Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RHistImpl.hxx:102:34: error: unknown type name 'CoordArray_t'
  • [2020-07-06T16:28:32.321Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RHistImpl.hxx:105:41: error: unknown type name 'CoordArray_t'
  • [2020-07-06T16:28:32.321Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RHistImpl.hxx:113:12: error: unknown type name 'CoordArray_t'

And 11 more

Warnings:

  • [2020-07-06T16:28:32.321Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RHist.hxx:98:81: warning: pack fold expression is a C++17 extension [-Wc++17-extensions]

@phsft-bot
Copy link

phsft-bot commented Jul 6, 2020

Build failed on mac1015/cxx17.
Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

  • [2020-07-06T16:44:28.652Z] FAILED: hist/histv7/G__ROOTHist.cxx lib/ROOTHist.pcm
  • [2020-07-06T16:44:30.552Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/build/include/ROOT/RHist.hxx:105:31: error: expected expression
  • [2020-07-06T16:44:30.552Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/build/include/ROOT/RHist.hxx:142:55: error: reference to non-static member function must be called
  • [2020-07-06T16:44:30.552Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/build/include/ROOT/RHist.hxx:170:47: error: reference to non-static member function must be called
  • [2020-07-06T16:44:30.552Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/build/include/ROOT/RHist.hxx:183:47: error: reference to non-static member function must be called
  • [2020-07-06T16:44:30.552Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/build/include/ROOT/RHistImpl.hxx:34:1: error: too few template parameters in template redeclaration
  • [2020-07-06T16:44:30.552Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/build/include/ROOT/RHistImpl.hxx:74:31: error: no template named 'CoordArray_t' in namespace 'ROOT::Experimental::Hist'
  • [2020-07-06T16:44:30.552Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/build/include/ROOT/RHistImpl.hxx:102:34: error: unknown type name 'CoordArray_t'
  • [2020-07-06T16:44:30.552Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/build/include/ROOT/RHistImpl.hxx:105:41: error: unknown type name 'CoordArray_t'
  • [2020-07-06T16:44:30.552Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/build/include/ROOT/RHistImpl.hxx:113:12: error: unknown type name 'CoordArray_t'

And 11 more

@phsft-bot
Copy link

phsft-bot commented Jul 6, 2020

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See cdash.
See console output.

Errors:

  • [2020-07-06T16:40:27.892Z] CUSTOMBUILD : fatal error : too many errors emitted, stopping now [-ferror-limit=] [C:\build\workspace\root-pullrequests-build\build\hist\histv7\G__ROOTHist.vcxproj]

@phsft-bot
Copy link

phsft-bot commented Jul 6, 2020

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

  • [2020-07-06T17:00:09.683Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RHist.hxx:105:31: error: expected expression
  • [2020-07-06T17:00:09.683Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RHist.hxx:142:49: error: no member named 'apply' in namespace 'std'
  • [2020-07-06T17:00:09.683Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RHist.hxx:170:41: error: no member named 'apply' in namespace 'std'
  • [2020-07-06T17:00:09.683Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RHist.hxx:183:41: error: no member named 'apply' in namespace 'std'
  • [2020-07-06T17:00:09.683Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RHistImpl.hxx:34:1: error: too few template parameters in template redeclaration
  • [2020-07-06T17:00:09.683Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RHistImpl.hxx:74:31: error: no template named 'CoordArray_t' in namespace 'ROOT::Experimental::Hist'
  • [2020-07-06T17:00:09.683Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RHistImpl.hxx:102:34: error: unknown type name 'CoordArray_t'
  • [2020-07-06T17:00:09.683Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RHistImpl.hxx:105:41: error: unknown type name 'CoordArray_t'
  • [2020-07-06T17:00:09.683Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RHistImpl.hxx:113:12: error: unknown type name 'CoordArray_t'
  • [2020-07-06T17:00:09.683Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RHistImpl.hxx:115:12: error: unknown type name 'CoordArray_t'

And 10 more

Warnings:

  • [2020-07-06T17:00:09.683Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RHist.hxx:98:81: warning: pack fold expression is a C++17 extension [-Wc++17-extensions]

@ferdymercury
Copy link
Collaborator

ferdymercury commented Apr 1, 2025

Closing due to #18191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hahnjo hahnjo Awaiting requested review from hahnjo hahnjo will be requested when the pull request is marked ready for review hahnjo is a code owner

Assignees

@lmoneta lmoneta

Labels

in:Hist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Axel-Naumann @phsft-bot @ferdymercury @lmoneta