Repair parsing error due to commented-out field token#59
Merged
petermeissner merged 1 commit intoropensci:pr59from Aug 19, 2020
Merged
Repair parsing error due to commented-out field token#59petermeissner merged 1 commit intoropensci:pr59from
petermeissner merged 1 commit intoropensci:pr59from
Conversation
'names' attribute [2] must be the same length as the vector [0]
188c301 to
c9eb21c
Compare
Contributor
|
Thanks, can you open an issue for that please. |
Contributor
|
@gittaca also, can you give a reproducible example, please. |
Contributor
Author
|
I included a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a line starts with
#but continues with one of the valid fields / tokens, this backtrace is produced:After removing the
#in this demo.txt, the test case will fail withnrow(parse_robotstxt(rtxt_ct)$permissions) == 1 isn't true.which I take that the error is avoided.Maybe the error results from somewhere in rt_get_fields.R? Maybe because one of the reg-exes detects the valid token (
[2]), but another detects the line as a comment ([0]), thus clashing atnames(fields) <- c("field", "value")?I've tinkered with the various reg-exes there for about an hour, but found no solution. Will instead remove the problematic file from my analysis to continue with that for now.
Please feel free to take over the PR. I hope the test is a useful start to find and fix the problem.