-
Notifications
You must be signed in to change notification settings - Fork 1
[FEAT] OIDC client backend #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellemaxwell
approved these changes
Feb 4, 2026
Contributor
daniellemaxwell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The work completed here to set up the OIDC client is thorough and the tests look good. I added a comment about potentially consolidating the Validate methods and one about the oidcclient tests.
…; update tests accordingly
…anization and readability
…SQL queries and store methods accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
Adds the
OIDCClientstore model and associated API backend. Does not include the UI for now, as the OIDC project was put on the back burner.Fixes SC-36929
Type of change
Acceptance criteria
I have added tests that verify the behavior, please let me know if you can see any further tests.
I used Cursor AI heavily during this project as a learning experience, and I did a thorough code review of it myself prior to submitting this PR as well as editing a ton of the code myself by hand where required. I performed step by step instructions, so that I could review this as it developed slowly, rather than all at once. I have looked at every line of this code myself after the bot got to it and edited a lot of the code. The tests are sometimes a bit messy, but from my review they do test the functionality successfully for errors.
Definition of Done
Reviewer(s) checklist