Skip to content

Version 0.8.9#63

Merged
rsgalloway merged 8 commits intomasterfrom
issue62/typeerror
May 17, 2025
Merged

Version 0.8.9#63
rsgalloway merged 8 commits intomasterfrom
issue62/typeerror

Conversation

@rsgalloway
Copy link
Owner

@rsgalloway rsgalloway commented May 15, 2025

Version 0.8.9 RC

@rsgalloway rsgalloway linked an issue May 15, 2025 that may be closed by this pull request
@rsgalloway rsgalloway marked this pull request as ready for review May 16, 2025 21:13
@rsgalloway rsgalloway requested a review from Copilot May 16, 2025 21:13
@rsgalloway rsgalloway self-assigned this May 16, 2025
@rsgalloway rsgalloway added the bug Something isn't working label May 16, 2025
@rsgalloway rsgalloway added this to the Version 0.9.0 milestone May 16, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates versioning from 0.8.8 to 0.8.9 while addressing issue #62 and enhancing tests for environment variable inheritance. Key changes include updates to test cases in tests/test_env.py to cover new inheritance scenarios, modifications to environment variable dictionaries, and a version bump in lib/envstack/init.py.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
tests/test_env.py Updated tests to validate additional environment vars and ensure inheritance across levels.
lib/envstack/util.py Changed variable substitution to cast the result to a string.
lib/envstack/init.py Bumped version number from 0.8.8 to 0.8.9.

@rsgalloway rsgalloway requested a review from Copilot May 17, 2025 14:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the version to 0.8.9 while expanding test coverage to address issues #58 and #62 related to inherited environment variables, and it slightly refactors variable substitution and environment initialization.

  • Updated tests in tests/test_env.py to validate the new inheritance behaviors and modifiers.
  • Modified util.py and env.py to ensure that environment values are converted to strings and resolved via safe_eval.
  • Bumped the package version in lib/envstack/init.py.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
tests/test_env.py Expanded tests for issues #58 and #62 with new inheritance modifiers and cleanup.
lib/envstack/util.py Enforced string conversion in variable substitution and added type conversion for expressions.
lib/envstack/env.py Updated environment initialization and resolution using safe_eval.
lib/envstack/init.py Version bump to 0.8.9.
Comments suppressed due to low confidence (1)

lib/envstack/util.py:405

  • Converting the value to a string may alter the behavior for non-string inputs; please verify that all consumers of substitute_variable expect string outputs or update the documentation accordingly.
return str(value)

@rsgalloway rsgalloway merged commit 8016a24 into master May 17, 2025
@rsgalloway rsgalloway deleted the issue62/typeerror branch May 17, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError on inherited int values

2 participants