Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the expansion modifiers functionality to prevent cyclical reference errors by returning empty strings instead of raising exceptions when cycles are detected. This changes the behavior from strict error handling to a more bash-like approach where cycles resolve to empty strings.
- Removes the
CyclicalReferenceexception raising behavior and returns empty strings for cyclic references - Adds comprehensive cycle detection using a
resolvingset parameter to track variables currently being resolved - Updates all test cases to expect empty strings instead of
CyclicalReferenceexceptions
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| lib/envstack/util.py | Complete refactor of evaluate_modifiers function with improved cycle detection and bash-like behavior |
| lib/envstack/env.py | Minor changes to iterate over list copies when modifying dictionaries during iteration |
| tests/test_util.py | Updates test cases to expect empty strings instead of CyclicalReference exceptions |
| tests/test_env.py | Adds new test for issue #59 and fixes formatting/syntax issues in existing tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.