Skip to content

fix: error on generating description from a long sentence#1463

Merged
cderv merged 3 commits intorstudio:mainfrom
atusy:bs4book-cjk
Apr 3, 2024
Merged

fix: error on generating description from a long sentence#1463
cderv merged 3 commits intorstudio:mainfrom
atusy:bs4book-cjk

Conversation

@atusy
Copy link
Collaborator

@atusy atusy commented Apr 3, 2024

fixes #1462

Copy link
Collaborator

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's more elegant than my fix. Thanks!

Just add a news item and we'll merge.

@atusy
Copy link
Collaborator Author

atusy commented Apr 3, 2024

Thanks! Added news.

Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

[skip ci]
@cderv cderv merged commit 65aed2a into rstudio:main Apr 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bs4_book error: Error in 1:max_n

3 participants