Skip to content

docs(accordion_panel_set): Dots are the new contents of the panel#989

Merged
gadenbuie merged 2 commits intomainfrom
docs/fix-dots-accordion-update
Feb 21, 2024
Merged

docs(accordion_panel_set): Dots are the new contents of the panel#989
gadenbuie merged 2 commits intomainfrom
docs/fix-dots-accordion-update

Conversation

@gadenbuie
Copy link
Copy Markdown
Member

Fixes #988

accordion_panel_update() previously inherited all params from accordion_panel, leading to confusion about the role of ....

In the future we should consider letting accordion_panel_update() update attributes of the panel and not just the contents.

@gadenbuie gadenbuie requested a review from cpsievert February 21, 2024 16:22
Copy link
Copy Markdown
Collaborator

@cpsievert cpsievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gadenbuie gadenbuie merged commit 5d82e07 into main Feb 21, 2024
@gadenbuie gadenbuie deleted the docs/fix-dots-accordion-update branch February 21, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants