Skip to content

Allow for isolate calls in a non-reactive context #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
schloerke merged 7 commits into from
Aug 26, 2020
Merged

Allow for isolate calls in a non-reactive context #68

schloerke merged 7 commits into from
Aug 26, 2020

Conversation

@schloerke
Copy link
Collaborator

@schloerke schloerke commented Aug 25, 2020

  • Do not attempt to add an edge to a non-context react id.
  • Add test=1 in the query string to put reactlog into shinytest mode. This helps with screenshot reproducibility (such as time and session ID)
  • Ran shinytest on example app

PR task list:

  • Update documentation with devtools::document()

@schloerke schloerke requested a review from wch August 25, 2020 15:04
@schloerke schloerke merged commit afb1740 into master Aug 26, 2020
@schloerke schloerke deleted the shinytest branch August 26, 2020 15:12
@schloerke schloerke mentioned this pull request Aug 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wch wch wch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@schloerke @wch