Skip to content

Commit e6d94f6

Browse files
authored
Fix regression in repeated appendTab()s when navbarMenu() is present (#3518)
1 parent 5a8a026 commit e6d94f6

5 files changed

Lines changed: 9 additions & 9 deletions

File tree

inst/www/shared/shiny.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

inst/www/shared/shiny.js.map

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

inst/www/shared/shiny.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

inst/www/shared/shiny.min.js.map

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

srcts/src/shiny/shinyapp.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1112,8 +1112,8 @@ class ShinyApp {
11121112
// loop through all existing tabs, find the one with highest id
11131113
// (since this is based on a numeric counter), and increment
11141114

1115-
$tabset.find("a[data-toggle='tab']").each(function () {
1116-
const $tab = $(this);
1115+
$tabset.find("> li").each(function () {
1116+
const $tab = $(this).find("> a[data-toggle='tab']");
11171117

11181118
if ($tab.length > 0) {
11191119
// remove leading url if it exists. (copy of bootstrap url stripper)

0 commit comments

Comments
 (0)