Fix regression in repeated appendTab()s when navbarMenu() is present#3518
Merged
Fix regression in repeated appendTab()s when navbarMenu() is present#3518
Conversation
d58a159 to
948ca15
Compare
cpsievert
commented
Sep 30, 2021
Comment on lines
+1115
to
+1116
| $tabset.find("> li").each(function () { | ||
| const $tab = $(this).find("> a[data-toggle='tab']"); |
Collaborator
Author
There was a problem hiding this comment.
This reverts the logic back to the way it was in the 1.6.0 release (
Lines 876 to 885 in b57cb6c
I originally changed this logic because, for a short period, we were working around a BS4 regression that dropped support for dropdown items wrapped in <li>. That regression has since been fixed and is now included with bs_theme(version = 4), so this change in logic is no longer needed
wch
approved these changes
Sep 30, 2021
schloerke
added a commit
that referenced
this pull request
Oct 1, 2021
* master: Update NEWS Use esbuild option preserveSymlinks Fix regression in repeated appendTab()s when navbarMenu() is present (#3518)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3516