TypeScript: Remove any types / improve type definitions#3414
Merged
TypeScript: Remove any types / improve type definitions#3414
any types / improve type definitions#3414Conversation
… it is an instance of HTMLElement
wch
approved these changes
Jun 14, 2021
schloerke
added a commit
that referenced
this pull request
Jun 15, 2021
* master: Move `./srcts` configs to top level to support types installation from GitHub (#3425) insertTab() now handles position correctly when target is NULL (#3404) yarn add node-gyp; yarn build (#3424) Export TypeScript type definitions to local folder (#3418) TypeScript: Remove `any` types / improve type definitions (#3414) Better color constrasting in sliderInput() (#3366) Use ggplot2::get_alt_text() if available to provide better default alt text (#3398) Set selectize dropdownParent to "body" to prevent clipping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Question
InsertPositiontypes for insert tab (ex: "beforeend") work in the browser? It currently expects a lowercase values such asbeforeend. See https://github.com/rstudio/shiny/pull/3414/files#diff-7aa61053d5a807425314d89085e38603c93b1c63a841d378e279aa3cd70417deR47-R49InsertPositionwherelocations #3421