feat: Add options for screenshot threshold and kernel_size#401
Merged
feat: Add options for screenshot threshold and kernel_size#401
threshold and kernel_size#401Conversation
schloerke
approved these changes
Feb 10, 2025
Collaborator
schloerke
left a comment
schloerke
left a comment
There was a problem hiding this comment.
If these changes look good to you, feel free to merge.
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two new options:
shinytest2.compare_screenshot.thresholdforcompare_screenshot_threshold(threshold=)shinytest2.compare_screenshot.kernel_sizeforcompare_screenshot_threshold(kernel_size=)Previously, these values required directly updating every
app$expect_screenshot(). This option will allow for making global changes, e.g. in shinycoreci.