Use cf-conventions to infer dimension names#106
Merged
nocollier merged 1 commit intorubisco-sfa:masterfrom Sep 26, 2024
Merged
Conversation
Currently ILAMB requires dimensions for time, latitude and longitude in NetCDF files to be called `time`, `lat` and `lon` respectively which is not CF-compliant. This change allows ILAMB to be more flexible in inferring the spatiotemporal dimension names by examining standard CF attributes on [coordinate types][cf_coordinate_types]. [cf_coordinate_types]: https://cfconventions.org/cf-conventions/cf-conventions.html#coordinate-types
7069ba2 to
d40f997
Compare
3 tasks
Contributor
Author
|
Hi @nocollier, requesting your review for this pull request |
Collaborator
|
Thanks for your contribution and your patience while I get to looking at it. I think this is great, and appreciate your effort to make ILAMB better. I just have a few comments to make in general in case you find yourself staring at a lot of my (ugly) code:
I am going to accept and merge this, and then will run some larger tests on our bigger comparisons in the week to come. Thanks! |
Contributor
Author
|
Hi @nocollier, can you push a new release to conda/pip containing these changes? We require these changes for our work and it would be convenient if they were available directly via conda. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently ILAMB requires dimensions for time, latitude and longitude in NetCDF files to be called
time,latandlonrespectively which is not CF-compliant. This change allows ILAMB to be more flexible in inferring the spatiotemporal dimension names by examining standard CF attributes on coordinate types.