Fixed JavaThreadPoolExecutor queue bug when minimum pool size is zero. #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdantonio
force-pushed
the
bug/java-thread-pool
branch
from
f67fb4a to
aa9b695
Compare
jdantonio
added a commit
that referenced
this pull request
Nov 26, 2014
Fixed JavaThreadPoolExecutor queue bug when minimum pool size is zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #182
The constructor was based on introspection of Java objects. Specifically this code:
I copied this behavior without reading the documentation of SynchronousQueue. In retrospect, it is clear that a synchronous queue, which always blocks and has a fixed size of zero, is not the behavior we want.