symbolized keys

[ghazel]

The symbolization of keys is a bit weird. There are some TODOs noted in consumer.rb:

      # symbolize keys
      # TODO this could be considered unexpected behavior; symbols or not?
      # TODO this also drops subsequent values from multi-valued keys
      CGI.parse(response.body).inject({}) do |h,(k,v)|
        h[k.strip.to_sym] = v.first
        h[k.strip]        = v.first
        h
      end

I noticed because access_token.params contains both types, which is quite odd. What's the plan here?

[pboling]

For query params the plan is to go with string keys... eventually. And symbol keys for config and options.

This is an extremely thorny problem due to the embedded nature of this logic. It appears to be referenced both ways in the code, and so we need both versions. This code base only has about 30% test coverage, and I'd love to not break everything, so this is going to remain as a gross bug for a while!

[pboling]

This gem will be switching to use snaky_hash for the consumer issue noted here.