Ensure BigMath.sin and BigMath.cos to be within -1..1#317
Merged
mrkn merged 1 commit intoruby:masterfrom Jun 17, 2025
Merged
Conversation
Member
|
@tompng, it may be advisable to apply a provisional adjustment so the result falls within each function’s valid range. |
511c216 to
c39cfc6
Compare
Member
Author
|
There is no loss of accuracy. Error decreases in every case. if master_branch_sin(x).abs <= 1
# no change, no accuracy loss
return master_branch_sin(x)
elsif master_branch_sin(x) > 1
return 1
# true_sin(x) <= this_pull_req_sin(x) == 1 <= master_branch_sin(x), so the error always decrease
elsif master_branch_sin(x) < -1
return -1
# master_branch_sin(x) < this_pull_req_sin(x) == 1 <= true_sin(x)
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BigMath.sin and cos was returning
> 1or<-1value in few cases.The precision is correct (
error < 1e-44), but sin and cos is often assumed to be within-1..1.