Don't use ZeroWrapLimited. Use unlimited version instead.#410
Merged
tompng merged 1 commit intoruby:masterfrom Aug 22, 2025
Merged
Don't use ZeroWrapLimited. Use unlimited version instead.#410tompng merged 1 commit intoruby:masterfrom
tompng merged 1 commit intoruby:masterfrom
Conversation
ZeroWrapLimited turned out to be useless in most case. In a few case that ZeroWrapLimited is needed, explicitly calculate precision is enough.
8c87a9e to
a23ea32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto limit allocation is not so good.
After several refactoring and bug fixes,
ZeroWrapLimitedturned out to be useless in most cases.It allocates with extra
Max(extra_sub_prec, extra_rounding_prec, extra_div_prec, extra_sqrt_prec, ...)DECDIGs. This value 2 is hardcoded.In a few case that ZeroWrapLimited is really needed, explicitly calculate precision is enough.
Remaining
NewZeroWrapLimitedandNewOneNolimitis only used insqrtand will be removed in #381