Don't use delegator to install helper methods to main object#1031
Merged
st0012 merged 1 commit intoruby:masterfrom Nov 19, 2024
Merged
Don't use delegator to install helper methods to main object#1031st0012 merged 1 commit intoruby:masterfrom
st0012 merged 1 commit intoruby:masterfrom
Conversation
IRB used delegator to install command as a method of frozen main object. Command is not a method now. We can drop it.
st0012
approved these changes
Nov 19, 2024
Member
st0012
left a comment
There was a problem hiding this comment.
Thanks. There are some refactors that I think can be done but I'll give them a try in a separate PR.
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Nov 19, 2024
object (ruby/irb#1031) IRB used delegator to install command as a method of frozen main object. Command is not a method now. We can drop it. ruby/irb@2f1c593801
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delegator was needed to install command methods to frozen objects, but we don't do it anymore.
Dropping delegator will fix this weird behavior.
Helper methods will be unavailable on frozen main object. However, I think it makes sense that frozen object can't have helper methods.
(We can change this by adding helper methods to Kernel instead of main object maybe in the future. It will also completely fix helper method polluting main object.)
This pull request also adds minimal support for BasicObject because the original delegator code was checking BasicObject.