Add missing check for rb_block_call() #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
FYI I'll workaround in TruffleRuby by always defining HAVE_RB_BLOCK_CALL (so existing racc releases work). We should merge this and have a release so the obsolete rb_iterate() is no longer used, though (https://bugs.ruby-lang.org/issues/18025). |
Member
Author
|
I'll merge this since it is an obvious fix. |
graalvmbot
pushed a commit
to truffleruby/truffleruby
that referenced
this pull request
Jul 9, 2021
graalvmbot
pushed a commit
to truffleruby/truffleruby
that referenced
this pull request
Jul 13, 2021
* Before the ruby/racc#165 fix (cherry picked from commit 39ef803)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, it would cause failures in TruffleRuby, since truffleruby/truffleruby@e7ddba7 (
rb_iterate()is obsolete since 1.9 https://github.com/ruby/ruby/blob/master/doc/extension.rdoc#label-Control+Structure, https://bugs.ruby-lang.org/issues/18025)It would be great to have a release with this fix soon to fix that, do you think that's possible @hsbt @tenderlove?