Add RBS type definition file jump to typeDefinition LSP feature#357
Open
S-H-GAMELINKS wants to merge 1 commit intoruby:masterfrom
Open
Add RBS type definition file jump to typeDefinition LSP feature#357S-H-GAMELINKS wants to merge 1 commit intoruby:masterfrom
S-H-GAMELINKS wants to merge 1 commit intoruby:masterfrom
Conversation
Previously, typeDefinition only jumped to Ruby class/module definitions. This change enables jumping to RBS declaration files from: - Class/module constants (e.g., Foo in Foo.new) - Local variables and instance variables holding class instances Also adds tests for both scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, typeDefinition only jumped to Ruby class/module definitions.
This change enables jumping to RBS declaration files from:
Also adds tests for both scenarios.
Screenshots
Jumping from class constant
Jumping from local variable