Fix request fulfilled issue #5334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorner
requested changes
Sep 12, 2025
| flash[:notice] = "Request started" | ||
| redirect_to new_distribution_path(request_id: request.id) | ||
| rescue ActiveRecord::RecordInvalid | ||
| flash[:alert] = "Request has already been fulfilled" |
Collaborator
There was a problem hiding this comment.
If you're going to take this path, you should be reading the actual error and displaying it, rather than assuming what the error could be.
Contributor
Author
There was a problem hiding this comment.
It's been updated to show the actual error now
flash[:alert] = request.errors.full_messages.to_sentence
Collaborator
|
@GreenGogh47 this looks good now, but can you please fix the conflicts? |
dorner
approved these changes
Oct 3, 2025
Collaborator
|
Passes technical review, over to @awwaiid for functional. |
Collaborator
|
Passed Functional Testing:
@ruestitch This looks good to me! |
Contributor
|
@GreenGogh47: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5326
Description
Originally it was possible to change the status of an already fulfilled request to "started".
This PR adds:
However, there are 5 failing tests that are unrelated to this pr. This is consistent with the current main branch. I just wanted to bring it to your attention.
Type of change
How Has This Been Tested?
Rspec tests have been added, and I've tested it manually.
