Skip to content

Conversation

@Tyler-Fanuele
Copy link
Contributor

@Tyler-Fanuele Tyler-Fanuele commented Sep 12, 2025

Addresses #5361

Modified storage_location model to include validate name for uniqueness within the scope of organization id, case sensitive false

modified storage_locations factory to use a sequence for the name as long as no name is given.

added a test for the validation in storage location spec

Modified storage_location system spec to test for same name and case insensitive name

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

How Has This Been Tested?

  • Update spec and system_spec tests.
  • Ran these tests in local dev environment to ensure proper completion.

Screenshots

image

Modified storage_location model to include validate name for uniqueness within the scope of orginization id, case sensitive false

modified storage_locations factory to use a sequence for the name as long as no name is given.

added a test for the validation in storage location spec

Modified storage_location system spec to test for same name and case insensitive name

Co-authored-by: Brody Fischer <[email protected]>
@awwaiid awwaiid changed the title Fix for #5361 Storage location name uniqueness Sep 12, 2025
Copy link
Collaborator

@awwaiid awwaiid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you!

@awwaiid awwaiid merged commit f906f01 into rubyforgood:main Sep 12, 2025
11 checks passed
@awwaiid awwaiid added this to the Ruby For Good 2025 DC milestone Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants